feat(p2p): send goodbye messages on disconnecting to peers #10920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dency with reqresp
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Maddiaa0
commented
Dec 20, 2024
| @@ -144,95 +143,6 @@ export class LibP2PService<T extends P2PClientType> extends WithTracer implement | |||
| }; | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
I just moved start and stop below the static initialiser just so that it was closer to the constructor
Maddiaa0
commented
Dec 20, 2024
| private proofVerifier: ClientProtocolCircuitVerifier, | ||
| private worldStateSynchronizer: WorldStateSynchronizer, | ||
| private telemetry: TelemetryClient, | ||
| private requestResponseHandlers: ReqRespSubProtocolHandlers = DEFAULT_SUB_PROTOCOL_HANDLERS, |
There was a problem hiding this comment.
No idea why i included these as a dependency, they are now just constructed in the start function, alongside the validators
Maddiaa0
force-pushed
the
md/ping-and-goodbye
branch
from
7f1e79d to
fa2d595
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When shutting down the node, or when disconnecting from a node that has suffered from a low peer score, we send a good bye message.
This goodbye message prompts the other node to also close their connection, allowing them to connect to more peers
Features:
Misc:
to split out the peer scoring component such that reqresp could still manage peer scores