[Az.DataProtection] Added support for UAMI in Backup Instance #26868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiaga
requested review from
isra-fel,
bilaakpan-ms,
Sandido,
haagha and
grizzlytheodore
as code owners
️✔️Az.Accounts
|
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| Edit-AzDataProtectionPolicyRetentionRuleClientObject | Edit-AzDataProtectionPolicyRetentionRuleClientObject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Edit-AzDataProtectionPolicyRetentionRuleClientObject | Edit-AzDataProtectionPolicyRetentionRuleClientObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Edit-AzDataProtectionPolicyTagClientObject | Edit-AzDataProtectionPolicyTagClientObject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Edit-AzDataProtectionPolicyTagClientObject | Edit-AzDataProtectionPolicyTagClientObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Edit-AzDataProtectionPolicyTriggerClientObject | Edit-AzDataProtectionPolicyTriggerClientObject Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Edit-AzDataProtectionPolicyTriggerClientObject | Edit-AzDataProtectionPolicyTriggerClientObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzDataProtectionBackupInstance | Get-AzDataProtectionBackupInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDataProtectionBackupInstance | Get-AzDataProtectionBackupInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzDataProtectionBackupInstancesExtensionRouting | Get-AzDataProtectionBackupInstancesExtensionRouting Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDataProtectionBackupInstancesExtensionRouting | Get-AzDataProtectionBackupInstancesExtensionRouting changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzDataProtectionBackupPolicy | Get-AzDataProtectionBackupPolicy Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDataProtectionBackupPolicy | Get-AzDataProtectionBackupPolicy changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzDataProtectionBackupVault | Get-AzDataProtectionBackupVault Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDataProtectionBackupVault | Get-AzDataProtectionBackupVault changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzDataProtectionJob | Get-AzDataProtectionJob Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDataProtectionJob | Get-AzDataProtectionJob changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzDataProtectionOperation | Get-AzDataProtectionOperation Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDataProtectionOperation | Get-AzDataProtectionOperation changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzDataProtectionOperationStatus | Get-AzDataProtectionOperationStatus Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDataProtectionOperationStatus | Get-AzDataProtectionOperationStatus changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzDataProtectionPolicyTemplate | Get-AzDataProtectionPolicyTemplate Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDataProtectionPolicyTemplate | Get-AzDataProtectionPolicyTemplate changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzDataProtectionRecoveryPoint | Get-AzDataProtectionRecoveryPoint Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDataProtectionRecoveryPoint | Get-AzDataProtectionRecoveryPoint changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzDataProtectionResourceGuard | Get-AzDataProtectionResourceGuard Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDataProtectionResourceGuard | Get-AzDataProtectionResourceGuard changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzDataProtectionResourceGuardMapping | Get-AzDataProtectionResourceGuardMapping Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDataProtectionResourceGuardMapping | Get-AzDataProtectionResourceGuardMapping changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzDataProtectionSoftDeletedBackupInstance | Get-AzDataProtectionSoftDeletedBackupInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzDataProtectionSoftDeletedBackupInstance | Get-AzDataProtectionSoftDeletedBackupInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Initialize-AzDataProtectionBackupInstance | Initialize-AzDataProtectionBackupInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Initialize-AzDataProtectionBackupInstance | Initialize-AzDataProtectionBackupInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Initialize-AzDataProtectionRestoreRequest | Initialize-AzDataProtectionRestoreRequest Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Initialize-AzDataProtectionRestoreRequest | Initialize-AzDataProtectionRestoreRequest changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzDataProtectionBackupConfigurationClientObject | New-AzDataProtectionBackupConfigurationClientObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzDataProtectionBackupVaultStorageSettingObject | New-AzDataProtectionBackupVaultStorageSettingObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzDataProtectionPolicyTagCriteriaClientObject | New-AzDataProtectionPolicyTagCriteriaClientObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzDataProtectionPolicyTriggerScheduleClientObject | New-AzDataProtectionPolicyTriggerScheduleClientObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzDataProtectionRestoreConfigurationClientObject | New-AzDataProtectionRestoreConfigurationClientObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzDataProtectionRetentionLifeCycleClientObject | New-AzDataProtectionRetentionLifeCycleClientObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Search-AzDataProtectionBackupInstanceInAzGraph | Search-AzDataProtectionBackupInstanceInAzGraph Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Search-AzDataProtectionBackupInstanceInAzGraph | Search-AzDataProtectionBackupInstanceInAzGraph changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Search-AzDataProtectionBackupVaultInAzGraph | Search-AzDataProtectionBackupVaultInAzGraph Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Search-AzDataProtectionBackupVaultInAzGraph | Search-AzDataProtectionBackupVaultInAzGraph changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Search-AzDataProtectionJobInAzGraph | Search-AzDataProtectionJobInAzGraph Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Search-AzDataProtectionJobInAzGraph | Search-AzDataProtectionJobInAzGraph changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
⚠️ Help Example Check
⚠️ PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ New-AzDataProtectionBackupVault 1 3 Mismatched_Parameter_Value_Type New-AzDataProtectionBackupVault -StorageSetting $storagesetting is not an expected parameter value type. -StorageSetting Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DataProtection.Models.Api20240401.IStorageSetting. Now the type is psobject.(Command). ⚠️ New-AzDataProtectionBackupVault 2 3 Mismatched_Parameter_Value_Type New-AzDataProtectionBackupVault -StorageSetting $storagesetting is not an expected parameter value type. -StorageSetting Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DataProtection.Models.Api20240401.IStorageSetting. Now the type is psobject.(Command). ⚠️ New-AzDataProtectionBackupVault 3 17 Mismatched_Parameter_Value_Type New-AzDataProtectionBackupVault -StorageSetting $storagesetting is not an expected parameter value type. -StorageSetting Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DataProtection.Models.Api20240401.IStorageSetting. Now the type is psobject.(Command). ⚠️ Set-AzDataProtectionMSIPermission 1 1 Unassigned_Variable Set-AzDataProtectionMSIPermission -BackupInstance $instance is a null-valued parameter value. -BackupInstance Assign value for $instance. ⚠️ Set-AzDataProtectionMSIPermission 2 1 Unassigned_Variable Set-AzDataProtectionMSIPermission -BackupInstance $instance is a null-valued parameter value. -BackupInstance Assign value for $instance. ⚠️ Set-AzDataProtectionMSIPermission 3 1 Unassigned_Variable Set-AzDataProtectionMSIPermission -BackupInstance $instance is a null-valued parameter value. -BackupInstance Assign value for $instance. ⚠️ Set-AzDataProtectionMSIPermission 4 1 Unassigned_Variable Set-AzDataProtectionMSIPermission -BackupInstance $backupInstance is a null-valued parameter value. -BackupInstance Assign value for $backupInstance. ⚠️ Update-AzDataProtectionBackupInstance 1 1 Unassigned_Variable Search-AzDataProtectionBackupInstanceInAzGraph -Subscription $subscriptionId is a null-valued parameter value. -Subscription Assign value for $subscriptionId. ⚠️ Update-AzDataProtectionBackupInstance 1 1 Unassigned_Variable Search-AzDataProtectionBackupInstanceInAzGraph -ResourceGroup $resourceGroupName is a null-valued parameter value. -ResourceGroup Assign value for $resourceGroupName. ⚠️ Update-AzDataProtectionBackupInstance 1 1 Unassigned_Variable Search-AzDataProtectionBackupInstanceInAzGraph -Vault $vaultName is a null-valued parameter value. -Vault Assign value for $vaultName. ⚠️ Update-AzDataProtectionBackupInstance 1 2 Unassigned_Variable Get-AzDataProtectionBackupPolicy -SubscriptionId $subscriptionId is a null-valued parameter value. -SubscriptionId Assign value for $subscriptionId. ⚠️ Update-AzDataProtectionBackupInstance 1 2 Unassigned_Variable Get-AzDataProtectionBackupPolicy -VaultName $vaultName is a null-valued parameter value. -VaultName Assign value for $vaultName. ⚠️ Update-AzDataProtectionBackupInstance 1 2 Unassigned_Variable Get-AzDataProtectionBackupPolicy -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName. ⚠️ Update-AzDataProtectionBackupInstance 1 4 Unassigned_Variable Update-AzDataProtectionBackupInstance -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName. ⚠️ Update-AzDataProtectionBackupInstance 1 4 Unassigned_Variable Update-AzDataProtectionBackupInstance -VaultName $vaultName is a null-valued parameter value. -VaultName Assign value for $vaultName. ⚠️ Update-AzDataProtectionBackupInstance 1 4 Mismatched_Parameter_Value_Type Update-AzDataProtectionBackupInstance -BackupInstanceName $instance.Name is not an expected parameter value type. -BackupInstanceName Use correct parameter value type. Expected Type is string. Now the type is .(Command). ⚠️ Update-AzDataProtectionBackupInstance 1 4 Unassigned_Variable Update-AzDataProtectionBackupInstance -SubscriptionId $subscriptionId is a null-valued parameter value. -SubscriptionId Assign value for $subscriptionId. ⚠️ Update-AzDataProtectionBackupInstance 1 4 Mismatched_Parameter_Value_Type Update-AzDataProtectionBackupInstance -VaultedBackupContainer $backedUpContainers[0,2,4] is not an expected parameter value type. -VaultedBackupContainer Use correct parameter value type. Expected Type is string. Now the type is .(Command).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️ File Change Check
⚠️ PowerShell Core - Windows
Type Cmdlet Description Remediation ⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version. ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.DataProtection. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
VeryEarly
reviewed
Dec 17, 2024
we have named UserAssignedIdentity in Update-AzDataProtectionbackupVault command which is a hashtable. so I named it UserAssignedidentityARMId in other commands to indicate the ARM ID. no other specific reason as such |
VeryEarly
approved these changes
Dec 17, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for UAMI in Backup Instance
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.