Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asdf 2.8.2 fixes #668

Merged
merged 4 commits into from
Dec 8, 2021
Merged

asdf 2.8.2 fixes #668

merged 4 commits into from
Dec 8, 2021

Conversation

CagtayFabry
Copy link
Member

Changes

  • name attribute should no longer propagate from NDArrayType with asdf 2.8.2
  • update asdf version

Related Issues

cref #110, #456,

Checks

  • updated CHANGELOG.rst
  • updated tests

@CagtayFabry CagtayFabry added ASDF everything ASDF related (python + schemas) dependencies changes in package dependencies labels Dec 8, 2021
@CagtayFabry CagtayFabry self-assigned this Dec 8, 2021
@CagtayFabry
Copy link
Member Author

the less np.asarray the better 🚀

@CagtayFabry CagtayFabry marked this pull request as ready for review December 8, 2021 10:10
@CagtayFabry CagtayFabry requested a review from vhirtham December 8, 2021 10:10
@github-actions
Copy link

github-actions bot commented Dec 8, 2021

Unit Test Results

       1 files  ±0         1 suites  ±0   2m 19s ⏱️ +30s
1 949 tests ±0  1 949 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit c5df600. ± Comparison against base commit a2c6af5.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #668 (c5df600) into master (a2c6af5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #668      +/-   ##
==========================================
- Coverage   96.12%   96.12%   -0.01%     
==========================================
  Files          91       91              
  Lines        5906     5903       -3     
==========================================
- Hits         5677     5674       -3     
  Misses        229      229              
Impacted Files Coverage Δ
weldx/tags/core/data_array.py 100.00% <ø> (ø)
weldx/tags/core/time_series.py 94.11% <100.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2c6af5...c5df600. Read the comment docs.

@CagtayFabry CagtayFabry merged commit 9cef0ce into BAMWelDX:master Dec 8, 2021
@CagtayFabry CagtayFabry deleted the asdf_282 branch December 8, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASDF everything ASDF related (python + schemas) dependencies changes in package dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants