-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selectively remove service transcript entry for banned programs #1176
Conversation
…atus in the table
…ate and remember it.
…is saving transcript status correctly
… tests. All tests are now passing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. There are lots of lines changed that did not need to be changed and there are also a couple variable nitpicks that it is taking every ounce of willpower to not request changes on but it looks like it works perfectly so I will abstain. Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Just a couple of minor changes in addition to the code comment.
- The edit button is a little too low, so it's not in line with the other elements in the row.
- 'Removed' shows up on a separate line for me. Let's replace 'Added!' and 'Removed!' with 'Saved' or 'Saving...', I think. It will be the same for both cases, then.
… the transcript message
…y the location of the pencil icon, modified the message by the checkbox
Issue: #658
Add a checkbox to the ban modal dialog to choose whether to completely remove the program from the service transcript or keep it in the service transcript (in case if the checkbox is not clicked). The checkbox on the modal should affect the service transcript directly and remove or keep the programs, whose modals were checked/unchecked.
Did:
removeFromTranscript
in programBan tableTest:
serviceTEntry658