Validate for Duplicate Event Entries within Multiple Offering Modal #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m save the modal and cleaned up code
bledsoef
requested changes
Sep 6, 2024
There was a problem hiding this comment.
Great work altogether! The only issue is an edge case where we get an error when trying to create an event in the multiple event offerings modal when one already exists in the database. It should probably prevent you from creating it in the first place. @stevensonmichel speak more with Lawrence about this he understands how it works.
…k which offerings failed to save and report that info to the user
…:BCStudentSoftwareDevTeam/celts into 1306-Multiple-Offering-Duplicate-Entries
…ransactions when one multiple offering fails and how we use the restructured outputs from the attemptSaveMultipleOfferings function
…correctly and refactored.
bledsoef
reviewed
Sep 13, 2024
bledsoef
reviewed
Sep 13, 2024
bledsoef
reviewed
Sep 13, 2024
bledsoef
reviewed
Sep 13, 2024
bledsoef
reviewed
Sep 13, 2024
…ering event without selecting a date
1 similar comment
|
We have made all the suggested changes and we're ready for a re-review of our PR |
bledsoef
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
There is no form validation preventing a user from creating multiple of the same event using the multiple offerings modal. Currently, when they try, the form submits and returns a warning that the "event already exists" because it is a duplicate event. This is not intended behavior and the user should be warned beforehand.
Fixes issue #1306
Changes
Dev Note: After careful consideration, we determined that we should prevent a user from creating two offerings of an event if they had the same name, date, start time, even when they have different end times. We cannot think of a situation when two events wouldn't be the same even with different end times.
Testing
First, prepare your local development environment and run the application
Preparation:
source setup.shdatabase/reset_database.sh testflask runNow, you should create an event under any program and click the slider to give the event multiple offerings.
In the modal, do your best to create duplicate events and save the event page. If you cannot create multiple offerings so that when you save the event, you get a warning message saying that the "event already exists", then our PR is working.
Try creating two events that have the same fields but differ once in each of the following areas per test:
All fields same except event name
All fields same except event date
All fields same except start time
e.x.
