Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all occurences of endDate #1362

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Conversation

bledsoef
Copy link
Contributor

@bledsoef bledsoef commented Nov 23, 2024

Issue Description

Fixes issue #1348

  • End date is current a field in our database for events but it is never needed nor necessary. Remove it from the database and wherever else it appears.

Changes

  • Deleted endDate from the event model
  • Deleted all unnecessary references to endDate in the tests.
  • It should be noted that endDate is still necessary in some instances for event preprocessing for recurring events, but it should never make it to the database.

Testing

  • Checkout 1348_remove_end_data
  • Source setup
  • Reset database
  • Run tests
  • Go through event functionality like creating recurring and non recurring events, viewing events, etc. and verify nothing is breaking or working incorrectly.
  • Look through code and tests.

@bledsoef bledsoef self-assigned this Dec 5, 2024
@bledsoef bledsoef marked this pull request as ready for review December 5, 2024 21:04
Copy link

github-actions bot commented Dec 5, 2024

View Code Coverage

@bledsoef
Copy link
Contributor Author

bledsoef commented Dec 5, 2024

@stevensonmichel
Copy link
Contributor

stevensonmichel commented Dec 23, 2024

I created a recurring on December 3rd, with the end date being December 23th. It successfully generated three weekly events, which occur on 3rd, 10th, and 17th. However, on the edit page for each, their start date is marked as 23rd.
Screenshot 2024-12-23 104427

That inconsistency needs to be addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants