Skip to content

Commit

Permalink
SWI-3338 Small Fix for 7.3.0 (#79)
Browse files Browse the repository at this point in the history
* update version

* shorthand only supported in 3.1

* dont run tests on schedule
  • Loading branch information
ckoegel authored Aug 30, 2023
1 parent c3fee66 commit a72df80
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 23 deletions.
40 changes: 19 additions & 21 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
name: Test

on:
schedule:
- cron: "0 4 * * *"
pull_request:
workflow_dispatch:

Expand All @@ -11,28 +9,28 @@ jobs:
name: Test
runs-on: ${{ matrix.os }}
strategy:
matrix:
matrix:
os: [windows-2022, windows-2019, ubuntu-20.04, ubuntu-22.04]
ruby-version: [2.6, 2.7, 3.0]
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Checkout
uses: actions/checkout@v3

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}

- name: Install Packages
run: bundle install
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}

- name: Test
run: rake
- name: Install Packages
run: bundle install

- name: Notify Slack of Failures
uses: Bandwidth/build-notify-slack-action@v1.0.0
if: failure() && !github.event.pull_request.draft
with:
job-status: ${{ job.status }}
slack-bot-token: ${{ secrets.SLACK_BOT_TOKEN }}
slack-channel: ${{ secrets.SLACK_CHANNEL }}
- name: Test
run: rake

- name: Notify Slack of Failures
uses: Bandwidth/build-notify-slack-action@v1.0.0
if: failure() && !github.event.pull_request.draft
with:
job-status: ${{ job.status }}
slack-bot-token: ${{ secrets.SLACK_BOT_TOKEN }}
slack-channel: ${{ secrets.SLACK_CHANNEL }}
2 changes: 1 addition & 1 deletion lib/bandwidth-iris/site.rb
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def get_totaltns()
end

def get_orders(size: 30, page: 1)
list = @client.make_request(:get, "#{@client.concat_account_path(SITE_PATH)}/#{id}/orders", {size:, page:})[0]
list = @client.make_request(:get, "#{@client.concat_account_path(SITE_PATH)}/#{id}/orders", {size: size, page: page})[0]
# TODO need additional documentaion
list
end
Expand Down
2 changes: 1 addition & 1 deletion lib/bandwidth-iris/version.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module BandwidthIris
# Version of this gem
VERSION = "7.2.0"
VERSION = "7.3.0"
end

0 comments on commit a72df80

Please sign in to comment.