Destroy release also destroys the cached release #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foudfou
changed the title
foudfou
changed the title
|
I'll keep the force flag and document it better if needed rather than change the behavior. Today storage is cheaper than networking and processing time if the user wants to bootstrap the release again. what do you think @cedwards ? |
|
I concur we do NOT want this deleting the release. Closing this one as will not do / works as designed. |
|
Fair enough. The first commit 62991b6 was about improving the documentation though. Would you still be interested in me rebasing to merge? |
|
@foudfou sure, improving documentation would be great, thanks. |
foudfou
force-pushed
the
715-destroy-release-cache
branch
from
925cb89 to
8996100
Compare
foudfou
force-pushed
the
715-destroy-release-cache
branch
from
8996100 to
bc54c30
Compare
|
Rebased. This is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarification for #715