-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #210
base: master
Are you sure you want to change the base?
Spelling #210
Changes from all commits
f2a1699
a8b3c09
d816544
7239e70
f0e9330
1489c23
9f56b33
f7d5653
b33ac36
53887f1
b301147
dbd306b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -210,7 +210,7 @@ After you make changes in `.arb` files you should do additional actions to regen | |
* Feature-based folder structure | ||
* Prefers composition over inheritance | ||
* Dependency Injection is implemented via `provider` | ||
* Prefers `StatelessWidget` and async UI update via `StreamBuidler` and `BehaviourSubject` & `StreamController` in controller classes | ||
* Prefers `StatelessWidget` and async UI update via `StreamBuilder` and `BehaviourSubject` & `StreamController` in controller classes | ||
* Prefers divide `Widgets` in small sub `Widgets` with `const` constructor(for better performance) if possible | ||
* Provides data to nested elements via `provider` | ||
* Prefers `Repository` pattern. Almost all network data is cached in local SQLite database. UI always displays data from single source. It may be network-only or from database(if data is cached). Doesn't cache and merge data in memory to achieve data consistency | ||
|
@@ -219,7 +219,7 @@ After you make changes in `.arb` files you should do additional actions to regen | |
* It is easy to understand what classes do | ||
* It is easy to navigate in IDE by typing start letters of name | ||
* One class = one file | ||
* Prefers `interfaces` for `Bussines Logic` and `Services` | ||
* Prefers `interfaces` for `Business Logic` and `Services` | ||
* Simple append `I` to implementation class name. `AccountFollowerAccountCachedListBloc` is implementation and `IAccountFollowerAccountCachedListBloc` is interface | ||
* Code readability: you can see small list of public methods/fields in interface file instead of exploring long file with implementations | ||
* It is useful to implement extensions for interfaces not for implementations | ||
|
@@ -231,7 +231,7 @@ After you make changes in `.arb` files you should do additional actions to regen | |
|
||
To build Fedi you need to specify Flutter version in [`.fvm/fvm_config.json`](.fvm/fvm_config.json) field `flutterSdkVersion`. | ||
|
||
You can achieve this by specifing your system Flutter version by using `flutter version $version` or using FVM | ||
You can achieve this by specifying your system Flutter version by using `flutter version $version` or using FVM | ||
|
||
#### Flutter Version Management(FVM) | ||
|
||
|
@@ -297,7 +297,7 @@ Install Flutter version used by this project | |
|
||
Link multi-module project dependencies | ||
|
||
`fvm pub global activaite melos` | ||
`fvm pub global activate melos` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ? |
||
`fvm flutter pub global run melos bootstrap` | ||
|
||
##### Copy default .env config | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,7 +23,7 @@ scripts: | |
flutter pub global run melos exec --ignore="*example*" -- \ | ||
flutter pub global run tuneup stats | ||
description: | | ||
Display packages code/fiels stats | ||
Display packages code/file stats | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This could be |
||
|
||
analyze: | ||
run: | | ||
|
@@ -498,7 +498,7 @@ scripts: | |
fastlane:frameit:metadata: | ||
run: | | ||
melos run fastlane:frameit:metadata:text --no-select && \ | ||
melos run fastlane:frameit:metadata:screenshtos --no-select | ||
melos run fastlane:frameit:metadata:screenshots --no-select | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ?? |
||
description: Upload all metadata to stores | ||
|
||
fastlane:frameit:metadata:text: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -212,33 +212,33 @@ class MessageLookup extends MessageLookupByLibrary { | |
MessageLookupByLibrary.simpleMessage("Веб-сайт"), | ||
"app_about_learnMore": MessageLookupByLibrary.simpleMessage("Детали"), | ||
"app_about_title": MessageLookupByLibrary.simpleMessage("О Fedi"), | ||
"app_acccount_my_customList_edit_account_action_add": | ||
"app_account_my_customList_edit_account_action_add": | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Some projects don't like changing localizations. (Others request it, it's about 50/50, and I generally guess wrong.) |
||
MessageLookupByLibrary.simpleMessage("Добавить"), | ||
"app_acccount_my_customList_edit_account_action_remove": | ||
"app_account_my_customList_edit_account_action_remove": | ||
MessageLookupByLibrary.simpleMessage("Удалить"), | ||
"app_acccount_my_customList_edit_action_delete_list": | ||
"app_account_my_customList_edit_action_delete_list": | ||
MessageLookupByLibrary.simpleMessage("Удалить список"), | ||
"app_acccount_my_customList_edit_action_save": | ||
"app_account_my_customList_edit_action_save": | ||
MessageLookupByLibrary.simpleMessage("Сохранить"), | ||
"app_acccount_my_customList_edit_added_header": | ||
"app_account_my_customList_edit_added_header": | ||
MessageLookupByLibrary.simpleMessage("Добавленные пользователи"), | ||
"app_acccount_my_customList_edit_description": | ||
"app_account_my_customList_edit_description": | ||
MessageLookupByLibrary.simpleMessage( | ||
"Записи в списке кэшируются на сервере. Добавление/Удаление аккаунтов только на новые опубликованные записи.\nВсе старые записи останутся в списке навсегда.\nМожно добавить только те аккаунты на которые вы подписаны."), | ||
"app_acccount_my_customList_edit_search_header": | ||
"app_account_my_customList_edit_search_header": | ||
MessageLookupByLibrary.simpleMessage("Добавить в ваш список"), | ||
"app_acccount_my_customList_edit_search_hint": | ||
"app_account_my_customList_edit_search_hint": | ||
MessageLookupByLibrary.simpleMessage( | ||
"Пользователи на которых вы подписаны"), | ||
"app_acccount_my_customList_list_action_add": | ||
"app_account_my_customList_list_action_add": | ||
MessageLookupByLibrary.simpleMessage("Создать список"), | ||
"app_acccount_my_customList_list_action_edit": | ||
"app_account_my_customList_list_action_edit": | ||
MessageLookupByLibrary.simpleMessage("Редактировать"), | ||
"app_acccount_my_customList_list_empty_subtitle": | ||
"app_account_my_customList_list_empty_subtitle": | ||
MessageLookupByLibrary.simpleMessage("Создайте новый сейчас."), | ||
"app_acccount_my_customList_list_empty_title": | ||
"app_account_my_customList_list_empty_title": | ||
MessageLookupByLibrary.simpleMessage("У вас нет списков."), | ||
"app_acccount_select_suggestion_header": | ||
"app_account_select_suggestion_header": | ||
MessageLookupByLibrary.simpleMessage("Быстрый доступ"), | ||
"app_account_action_block": | ||
MessageLookupByLibrary.simpleMessage("Блокировать"), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some projects don't like changing changelogs. Happy to drop this or any other change.