-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added OnClick and OnMouse actions for Canvas #84
base: master
Are you sure you want to change the base?
Added OnClick and OnMouse actions for Canvas #84
Conversation
This reverts commit f3b230e.
I accidentally continued working with other things on the same branch. That has been reverted now. I'm new to making Pull Requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, perfect addition to the Canvas!
There are some other Events that can also be added however: OnPointerDown, OnPointerUp, OnPointerMove
Did |
Hey @ummerland I must have missed a notification at some point, sorry. But I added the handlers you described now. And added the handler that @Thaina requested as well together with the |
Very nice, thanks @KristofferStrube |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good and practical addition, clean code
@ummerland Do we have any chance this would be updated in nuget? Or we need to build this ourselves? It seem this repo don't get any updated for a whole year |
Sorry for the late update, we coming to this package and get review the feature PR and also update the package to .NET 5.0, thanks for the contrib. |
@attilah regarding the conflict with |
@tbm0115 I had some problems with my merge as you can see, but there are no conflicts now. You can just squash my commits. |
Hi, I'm wondering if this change made it into the release, or maybe it got lost somewhere? I get an error System.InvalidOperationException: Object of type 'Blazor.Extensions.Canvas.BECanvas' does not have a property matching the name 'onmousedown' |
Hey @neilgd, |
Any chance this is going to be merged at some point? Been sitting here for quite a while. |
As described in issue #83