Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minecraft:damage_sensor #185

Closed
DaanV2 opened this issue Oct 12, 2023 · 0 comments · Fixed by #194
Closed

Update minecraft:damage_sensor #185

DaanV2 opened this issue Oct 12, 2023 · 0 comments · Fixed by #194
Labels
good first issue Good for newcomers Hacktoberfest Hacktoberfest help wanted Extra attention is needed

Comments

@DaanV2
Copy link
Contributor

DaanV2 commented Oct 12, 2023

Microsoft has apparently updated the documentation. The damage_sensor should reflect that :)

MicrosoftDocs/minecraft-creator#62

@DaanV2 DaanV2 added good first issue Good for newcomers help wanted Extra attention is needed Hacktoberfest Hacktoberfest labels Oct 12, 2023
r4isen1920 added a commit to r4isen1920/Minecraft-bedrock-json-schemas that referenced this issue Nov 14, 2023
The list of damage sources have been updated and added new possible damage sources.

Damage source `attack` has been deprecated going forward and has been split into two, namely: `entity_attack` and `entity_explosion`.

Damage source `fatal` has also been deprecated in newer format/`min_engine` versions, and has caused content log errors upon testing. But will remain for backwards compatibility.

This commit aims to resolve Blockception#185. Please refer to the damage sensor documentation here: https://github.com/MicrosoftDocs/minecraft-creator/blob/main/creator/Reference/Content/EntityReference/Examples/EntityComponents/minecraftComponent_damage_sensor.md
@DaanV2 DaanV2 linked a pull request Nov 15, 2023 that will close this issue
DaanV2 pushed a commit that referenced this issue May 28, 2024
…enum (#290)

* Implement some missing `ui/` schemas

- Add `allow_debug_missing_texture`
- Add `propagate_alpha`
- Add `use_child_anchors`

* Tweak descriptions of `item_ref`

It should be noted that UI are referred to as "elements."

Moreover, the examples used colon (`:`) instead of dots (`.`) which contradicts the given description.

* Add more enum values to the `easing` property

These are all known values, aside from the five that was given.

* Update damage_source.json

The list of damage sources have been updated and added new possible damage sources.

Damage source `attack` has been deprecated going forward and has been split into two, namely: `entity_attack` and `entity_explosion`.

Damage source `fatal` has also been deprecated in newer format/`min_engine` versions, and has caused content log errors upon testing. But will remain for backwards compatibility.

This commit aims to resolve #185. Please refer to the damage sensor documentation here: https://github.com/MicrosoftDocs/minecraft-creator/blob/main/creator/Reference/Content/EntityReference/Examples/EntityComponents/minecraftComponent_damage_sensor.md

* Define `pack_scope` and `product_type` fields for pack manifests

With the release of Add-Ons in the marketplace, these property fields have become present in pack manifests.

* Tweak RegExp for defining texture names

- It will now match for a colon text (`:`) whereby namespaces are defined with
- Fix completely off-the-mark RegExp for `item_texture.json` and `terrain_texture.json` files.

* Add `FANCY` material enum

* Merge branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Hacktoberfest Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant