Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minecraft:damage_sensor damage sources #194

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

r4isen1920
Copy link
Contributor

This pull request aims to resolve issue #185 and update the current list of damage sources. Kindly check commit 1bbdb01 for your perusal.

Thank you and have a nice day!

- Add `allow_debug_missing_texture`
- Add `propagate_alpha`
- Add `use_child_anchors`
It should be noted that UI are referred to as "elements."

Moreover, the examples used colon (`:`) instead of dots (`.`) which contradicts the given description.
These are all known values, aside from the five that was given.
The list of damage sources have been updated and added new possible damage sources.

Damage source `attack` has been deprecated going forward and has been split into two, namely: `entity_attack` and `entity_explosion`.

Damage source `fatal` has also been deprecated in newer format/`min_engine` versions, and has caused content log errors upon testing. But will remain for backwards compatibility.

This commit aims to resolve Blockception#185. Please refer to the damage sensor documentation here: https://github.com/MicrosoftDocs/minecraft-creator/blob/main/creator/Reference/Content/EntityReference/Examples/EntityComponents/minecraftComponent_damage_sensor.md
@DaanV2 DaanV2 linked an issue Nov 15, 2023 that may be closed by this pull request
@DaanV2 DaanV2 self-requested a review November 15, 2023 20:38
Copy link
Contributor

@DaanV2 DaanV2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the work

@DaanV2 DaanV2 merged commit 6116476 into Blockception:main Nov 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update minecraft:damage_sensor
2 participants