Only configure publisher confirmation callbacks once during external …

…bus initialisation (#3256)
BrighterCommand · Aug 13, 2024 · 02cbf36 · 02cbf36
1 parent 3430d02
commit 02cbf36
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/src/Paramore.Brighter/CommandProcessor.cs b/src/Paramore.Brighter/CommandProcessor.cs
@@ -172,8 +172,6 @@ public CommandProcessor(IAmARequestContextFactory requestContextFactory,
             _transformPipelineBuilder = new TransformPipelineBuilder(mapperRegistry, messageTransformerFactory);
 
             InitExtServiceBus(policyRegistry, outBox, outboxTimeout, producerRegistry, outboxBulkChunkSize);
-
-            ConfigureCallbacks(producerRegistry);
         }
 
         /// <summary>
@@ -220,8 +218,6 @@ public CommandProcessor(IAmASubscriberRegistry subscriberRegistry,
             _transformPipelineBuilder = new TransformPipelineBuilder(mapperRegistry, messageTransformerFactory);
 
             InitExtServiceBus(policyRegistry, outBox, outboxTimeout, producerRegistry, outboxBulkChunkSize);
-
-            ConfigureCallbacks(producerRegistry);
         }
 
         /// <summary>
@@ -261,8 +257,6 @@ public CommandProcessor(IAmASubscriberRegistry subscriberRegistry,
             _transformPipelineBuilder = new TransformPipelineBuilder(mapperRegistry, messageTransformerFactory);
 
             InitExtServiceBus(policyRegistry, outBox, outboxTimeout, producerRegistry, outboxBulkChunkSize);
-
-            ConfigureCallbacks(producerRegistry);
         }
 
         /// <summary>
@@ -815,8 +809,7 @@ private void AssertValidSendPipeline<T>(T command, int handlerCount) where T : c
                     $"No command handler was found for the typeof command {typeof(T)} - a command should have exactly one handler.");
         }
 
-
-        private void ConfigureCallbacks(IAmAProducerRegistry producerRegistry)
+        private static void ConfigureCallbacks(IAmAProducerRegistry producerRegistry)
         {
             //Only register one, to avoid two callbacks where we support both interfaces on a producer
             foreach (var producer in producerRegistry.Producers)
@@ -871,6 +864,8 @@ private static void InitExtServiceBus(
                         _bus.PolicyRegistry = policyRegistry;
                         _bus.ProducerRegistry = producerRegistry;
                         _bus.OutboxBulkChunkSize = outboxBulkChunkSize;
+
+                        ConfigureCallbacks(producerRegistry);
                     }
                 }
             }