Add Default Message Mapper #3407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preardon
requested review from
iancooper,
holytshirt and
DevJonny
as code owners
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
iancooper
reviewed
Dec 3, 2024
src/Paramore.Brighter.Extensions.DependencyInjection/ServiceCollectionExtensions.cs
Show resolved
Hide resolved
iancooper
reviewed
Dec 3, 2024
src/Paramore.Brighter.Extensions.DependencyInjection/ServiceCollectionMessageMapperRegistry.cs
Show resolved
Hide resolved
iancooper
reviewed
Dec 3, 2024
|
|
||
| var header = new MessageHeader(messageId: request.Id, topic: publication.Topic, messageType: messageType); | ||
|
|
||
| var body = new MessageBody(JsonSerializer.Serialize(request, JsonSerialisationOptions.Options)); |
There was a problem hiding this comment.
In principle there is an async serializer. I am not sure if it actually has meaning. But we should investigate. The MS route here is to pass an enum flag to the common method and then just use sync or async code in the body, based on that flag as needed
There was a problem hiding this comment.
See the Flag Argument Hack here: https://learn.microsoft.com/en-us/archive/msdn-magazine/2015/july/async-programming-brownfield-async-development
iancooper
approved these changes
Dec 3, 2024
preardon
force-pushed
the
DefaultMessageMapper
branch
from
cb9fc8d to
f04c96a
Compare
preardon
force-pushed
the
DefaultMessageMapper
branch
from
f04c96a to
edcbda9
Compare
preardon
force-pushed
the
DefaultMessageMapper
branch
from
edcbda9 to
304dc98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First look into Default Message Mapper
#3355