Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dangling reference in Construct_center_3(Circle_3) #8586

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
ee451ed
Fix dangling reference in Construct_center_3(Circle_3)
MaelRL Nov 2, 2024
dd2fca2
Actually test the full EPECK family
MaelRL Nov 3, 2024
425fe50
Add missing tests for filtered Cartesian kernels
MaelRL Nov 3, 2024
69c9aba
Remove obsolete debug cout
MaelRL Nov 3, 2024
b32491a
Revert sidechange
MaelRL Nov 3, 2024
181ccd2
More instances of result_type --> dcltype(auto)
MaelRL Nov 6, 2024
b02776b
Remove wrong result_type (WIP: does not compile anymore)
MaelRL Nov 6, 2024
0d452b7
Remove extra parenthesis
MaelRL Nov 12, 2024
dcb38f3
Fix broken doc link
MaelRL Nov 12, 2024
a052572
Remove unused functor
MaelRL Dec 12, 2024
ea9c2a3
Remove unused functors
MaelRL Dec 12, 2024
8524c6a
Remove unused functors
MaelRL Dec 12, 2024
abc4fe6
Remove unused Lazy_rep objects
MaelRL Dec 17, 2024
db1fa6d
Factorize Lazy_construction_object into a single operator()
MaelRL Dec 17, 2024
7f1e16d
Factorize operator()s of Lazy_construction_variant
MaelRL Dec 17, 2024
4783005
Remove unused functor
MaelRL Dec 17, 2024
9188e8a
Fix name: polygonal_envelope > polyhedral_envelope
MaelRL Dec 17, 2024
9d10860
Use a single Lazy_construction class
MaelRL Dec 18, 2024
7b6755f
Remove code that was used to filter between different lazy constructions
MaelRL Dec 18, 2024
778ae1b
Remove unused class
MaelRL Dec 20, 2024
9c9892c
Use variadic functions in Static_filtered_predicate
MaelRL Dec 20, 2024
6b1e666
Remove superfluous code in Lazy_construction
MaelRL Dec 20, 2024
e534750
Fix but don't fix broken Has_static_filters for EPECK
MaelRL Dec 20, 2024
a886420
Misc cleaning
MaelRL Dec 20, 2024
468dde7
Use a clearer name than "Static_filtered_predicate" for EPECK static …
MaelRL Dec 20, 2024
4d4549c
Get rid of result_type in Kernels + fix some bad return types (wip)
MaelRL Dec 20, 2024
9c517a4
Fix bad return types
MaelRL Dec 20, 2024
c22fada
Do not rely on the predicate providing result_type in Filtered_predicate
MaelRL Dec 20, 2024
7b6886e
Misc cleaning
MaelRL Dec 20, 2024
7b160e3
Template the Uncertain enum_cast overload with Uncertain, not base enum
MaelRL Dec 29, 2024
c85b388
Update test for enum_cast<Uncertain>
MaelRL Dec 29, 2024
040f965
Fix include filename
MaelRL Dec 29, 2024
f26f41c
Minor CH3 test improvement
MaelRL Dec 29, 2024
b7de40a
Update enum_cast<Uncertain> calls to new API
MaelRL Jan 8, 2025
b8830ca
Remove superfluous precision
MaelRL Jan 8, 2025
8c95fcc
Update Filtered_predicate_with_state not to rely on a 'result_type' t…
MaelRL Jan 8, 2025
d02e817
Get rid of result types in function objects of Circular_kernel_23
MaelRL Jan 8, 2025
981e68c
Fix using non-existant has_on_2 API
MaelRL Jan 8, 2025
30064c1
Do not return const values
MaelRL Jan 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Cartesian_kernel/include/CGAL/Cartesian/Circle_3.h
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,12 @@ class CircleC3 {
return diametral_sphere();
}

Point_3 center() const
decltype(auto) center() const
{
return diametral_sphere().center();
}

FT squared_radius() const
decltype(auto) squared_radius() const
{
return diametral_sphere().squared_radius();
}
Expand All @@ -155,7 +155,7 @@ class CircleC3 {
return CGAL_PI * CGAL_PI * 4.0 * to_double(squared_radius());
}

FT area_divided_by_pi() const
decltype(auto) area_divided_by_pi() const
{
return squared_radius();
}
Expand Down
2 changes: 2 additions & 0 deletions Cartesian_kernel/include/CGAL/Cartesian/Sphere_3.h
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ typename R::Oriented_side
SphereC3<R>::
oriented_side(const typename SphereC3<R>::Point_3_ &p) const
{
typedef typename R::Oriented_side Oriented_side;
return enum_cast<Oriented_side>(bounded_side(p)) * orientation();
}

Expand All @@ -172,6 +173,7 @@ typename R::Bounded_side
SphereC3<R>::
bounded_side(const typename SphereC3<R>::Point_3_ &p) const
{
typedef typename R::Bounded_side Bounded_side;
return enum_cast<Bounded_side>(compare(squared_radius(),
squared_distance(center(), p)));
}
Expand Down
2 changes: 1 addition & 1 deletion Cartesian_kernel/include/CGAL/Cartesian/Tetrahedron_3.h
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ oriented_side(const typename TetrahedronC3<R>::Point_3 &p) const
{
typename R::Orientation o = orientation();
if (o != ZERO)
return enum_cast<Oriented_side>(bounded_side(p)) * o;
return enum_cast<typename R::Oriented_side>(bounded_side(p)) * o;

CGAL_kernel_assertion (!is_degenerate());
return ON_ORIENTED_BOUNDARY;
Expand Down
Loading