Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clear): reorganise file_paths manipulation logic #109

Conversation

tjzegmott
Copy link
Contributor

Description

Related Issue

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Tarik Zegmott <tarik.zegmott@mcgill.ca>
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Coverage Status

coverage: 66.796% (+0.08%) from 66.719%
when pulling 80f0f2d on 107-bug-datatrail-clear-command-failing-to-clear-staged-basebandraw-data-on-arc-1
into aabcad1 on main.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.79%. Comparing base (aabcad1) to head (80f0f2d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   66.71%   66.79%   +0.07%     
==========================================
  Files          14       14              
  Lines        1286     1286              
==========================================
+ Hits          858      859       +1     
+ Misses        428      427       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MWSammons MWSammons merged commit fd14f9b into main Sep 5, 2024
2 checks passed
@MWSammons MWSammons deleted the 107-bug-datatrail-clear-command-failing-to-clear-staged-basebandraw-data-on-arc-1 branch September 6, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] datatrail clear command failing to clear staged baseband.raw data on arc
3 participants