Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Committing query shopcart by price #61

Merged
merged 2 commits into from
Mar 31, 2024
Merged

Conversation

alvaroperezc
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.72%. Comparing base (2588ee4) to head (8d0626d).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   96.66%   96.72%   +0.06%     
==========================================
  Files          11       11              
  Lines         420      428       +8     
==========================================
+ Hits          406      414       +8     
  Misses         14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@whykay-01 whykay-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve the code coverage and make sure you test things out properly before pushing

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to create a test case for the line 151, so that the codecov report would stop complaining.

@alvaroperezc alvaroperezc requested a review from whykay-01 March 31, 2024 04:22
@alvaroperezc
Copy link
Contributor Author

Please improve the code coverage and make sure you test things out properly before pushing

Please review again @whykay-01 . I originally pushed because I thought you asked me to. Sorry if I misinterpreted. I wouldn't have otherwise pushed.

@vidishaholsambre vidishaholsambre merged commit cc3e1f7 into master Mar 31, 2024
3 checks passed
@vidishaholsambre vidishaholsambre deleted the Query-shopcart-by-price branch March 31, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants