[WIP] Removing SendGrid UI #3615
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Option from the Email System setting. Also, adds filter to allow users to change email settings should they so choose to use SendGrid.
Shelob9
requested changes
Aug 31, 2020
There was a problem hiding this comment.
@riverBanjo This looks good overall. I left some inline comments with some concerns about the filter.
|
|
||
| return self::$settings; | ||
| return apply_filters( 'change_email_settings', self::$settings, $arg1, $arg2 ); |
There was a problem hiding this comment.
@riverBanjo This filter is in the right place. A few concerns:
- Filter names should be prefeixed with
caldera_forms_ - $arg1 and $arg2 are undefined. Please delete those.
- There are no inline docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes SendGrid UI and add a hook to control the SendGrid email settings.
Fixes #3614
What has changed?
How to test?