Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 2024-10-28 #533

Merged
merged 15 commits into from
Oct 29, 2024
Merged

release: 2024-10-28 #533

merged 15 commits into from
Oct 29, 2024

Conversation

vdelacruzb
Copy link
Contributor

Release 2024-10-28

Changelog

Version

  • bigquery: v1.2.4
  • snowflake: v1.2.6
  • redshift: v1.1.2
  • postgres: v1.3.1

github-actions bot and others added 13 commits July 2, 2024 15:44
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Jesús Arroyo Torrens <jarroyo@cartodb.com>
Co-authored-by: Valentin de la Cruz Barquero <6054336+vdelacruzb@users.noreply.github.com>
Co-authored-by: Javier Goizueta <jgoizueta@gmail.com>
Co-authored-by: Alberto Hernández <albertoh@cartodb.com>
Co-authored-by: Pedro-Juan Ferrer <pedrof@carto.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: vdelacruzb <vdelacruzb@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…raries/python (#518)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@vdelacruzb vdelacruzb requested a review from volaya October 28, 2024 15:43
@vdelacruzb vdelacruzb changed the base branch from main to stable October 28, 2024 15:43
Copy link
Contributor

@DeanSherwin DeanSherwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it LGTM

I just left some comments on the docs regarding vocabulary. I think we should be consistent is using parameter names when describing functionality.

clouds/bigquery/modules/doc/h3/H3_FROMGEOGPOINT.md Outdated Show resolved Hide resolved
clouds/postgres/modules/doc/h3/H3_FROMGEOGPOINT.md Outdated Show resolved Hide resolved
clouds/snowflake/modules/doc/h3/H3_FROMGEOGPOINT.md Outdated Show resolved Hide resolved
@vdelacruzb vdelacruzb merged commit 1ddd3ed into stable Oct 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants