Test and fix bad positions in conflict message #756
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #755, which this fixes for the lcalc interpreter ;
however, the real issue is the OCaml (and other) backends, where it's much harder.
Indeed, for those, the positions are passed as a flat list to the top-level default term, which has no information anymore about nested exceptions. The only reliable way I see to fix that is to switch evaluated default terms from
'a option
to('a * pos) option
, and remove the the flat list of positions. It requires a change in the type of thehandle_exceptions
primitive, but it shouldn't be too difficult now that positions can be reified.