Update openai.ts

[YINGXINGHUA]

💻 变更类型 | Change Type

• feat
• fix
• refactor
• perf
• style
• test
• docs
• ci
• chore
• build

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

Summary by CodeRabbit

• New Features

  • Improved handling of token limits in chat requests, ensuring optimal performance based on model configuration.

• Bug Fixes

  • Enhanced error handling for unauthorized access, providing clearer feedback to users when issues arise with usage queries.

[vercel]

@YINGXINGHUA is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

The changes in this pull request focus on the ChatGPTApi class within the app/client/platforms/openai.ts file. Modifications include updates to the chat method for constructing request payloads, specifically ensuring the max_tokens parameter is set correctly based on model configurations. Additionally, the error handling in the usage method has been improved to provide specific error messages for unauthorized access and to ensure successful fetch requests before processing.

Changes

File Path	Change Summary
app/client/platforms/openai.ts	- Updated chat method to ensure max_tokens is set to the max of model's max_tokens and 1024, with adjustments for vision models. - Enhanced error handling in usage method for unauthorized access and ensured successful fetch requests.

Possibly related PRs

• fix no max_tokens in payload when the vision model name does not cont… #5304: Addresses a bug related to the handling of the max_tokens parameter in the ChatGPTApi class.
• fix: remove the visual model judgment method that checks if the model… #5415: Modifies the logic for setting the max_tokens parameter in the ChatGPTApi class for vision models.
• Feature fix openai function call #5489: Enhances management of tool call indices in the ChatGPTApi, potentially relating to chat methods.
• google gemini support function call #5581: Changes in the GeminiProApi class that may affect how ChatGPTApi interacts with models.
• fix: [#5574] readme #5608: Updates README documentation providing context for the modified functionalities.
• Update README.md #5722: Similar to fix: [#5574] readme #5608, updates README documentation to enhance user understanding of changes.

Suggested labels

planned

Suggested reviewers

• Dogtiti
• mayfwl

🐰 In the code, we hop and play,
Setting tokens in a clever way.
Errors caught, no more delay,
Chatting smoothly, come what may!
With each change, we leap and sway,
To brighter paths, we find our way! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

app/client/platforms/openai.ts (1)

232-232: Consider extracting magic numbers and improving documentation.

While the max_tokens logic is functional, consider these improvements:

1. Extract the magic numbers (1024) to named constants
2. Replace the informal comment with proper technical documentation explaining the rationale

+ // Minimum token limits for different model types
+ const MIN_TOKENS = {
+   DEFAULT: 1024,
+   VISION: 4000
+ } as const;
+
  // ...
- max_tokens: Math.max(modelConfig.max_tokens, 1024),
+ max_tokens: Math.max(modelConfig.max_tokens, MIN_TOKENS.DEFAULT),
- // Please do not ask me why not send max_tokens, no reason, this param is just shit, I dont want to explain anymore.
+ // Note: Enforcing minimum token limit to ensure sufficient response length

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d66bfc6 and a60ee08.

📒 Files selected for processing (1)

• app/client/platforms/openai.ts (1 hunks)

🔇 Additional comments (1)

app/client/platforms/openai.ts (1)

Line range hint 479-481: LGTM: Improved error handling with proper status checks.

The error handling improvements are well implemented:

• Specific handling for unauthorized access (401)
• Proper validation of both API responses
• Localized error messages

Also applies to: 483-485

[lloydzhou]

这个 应该是之前某个版本的时候，特意这么处理的。暂时不打算打开

[Issues-translate-bot]

Bot detected the issue body's language is not English, translate it automatically.

---

This should have been deliberately handled this way in a previous version. Not planning to open it yet