Merge pull request ddnet#9367 from Robyt3/Demo-Extract-Stack-Overflow…

…-Fix Fix stack-overflow in `demo_extract_chat` tool
ChillerDragon · Dec 9, 2024 · fd34043 · fd34043
2 parents cfefe25 + 6002f0f
commit fd34043
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/tools/demo_extract_chat.cpp b/src/tools/demo_extract_chat.cpp
@@ -9,6 +9,8 @@
 
 #include <game/gamecore.h>
 
+#include <memory>
+
 static const char *TOOL_NAME = "demo_extract_chat";
 
 class CClientSnapshotHandler
@@ -195,8 +197,8 @@ class CDemoPlayerMessageListener : public CDemoPlayer::IListener
 
 static int ExtractDemoChat(const char *pDemoFilePath, IStorage *pStorage)
 {
-	CSnapshotDelta DemoSnapshotDelta;
-	CDemoPlayer DemoPlayer(&DemoSnapshotDelta, false);
+	std::unique_ptr<CSnapshotDelta> pDemoSnapshotDelta = std::make_unique<CSnapshotDelta>();
+	CDemoPlayer DemoPlayer(pDemoSnapshotDelta.get(), false);
 
 	if(DemoPlayer.Load(pStorage, nullptr, pDemoFilePath, IStorage::TYPE_ALL_OR_ABSOLUTE) == -1)
 	{