Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests affected by missing schema descriptions #6815

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Jan 12, 2024

Summary of the changes (Less than 80 chars)

  • Fixed tests affected by missing schema descriptions by adding descriptions to the types.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (01daf1e) 69.52% compared to head (afdbf89) 69.69%.

Files Patch % Lines
...es/Types/Directives/TagDirectiveConfigAttribute.cs 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6815      +/-   ##
==========================================
+ Coverage   69.52%   69.69%   +0.17%     
==========================================
  Files        2481     2499      +18     
  Lines      125456   126162     +706     
==========================================
+ Hits        87219    87925     +706     
  Misses      38237    38237              
Flag Coverage Δ
unittests 69.69% <72.72%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glen-84 glen-84 requested a review from michaelstaib April 11, 2024 10:56
@michaelstaib michaelstaib merged commit 21a8ad5 into ChilliCream:main Apr 11, 2024
4 of 6 checks passed
@glen-84 glen-84 deleted the fix-tests branch April 11, 2024 11:02
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants