Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked Promise Caching for Batching. #6919

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

michaelstaib
Copy link
Member

No description provided.

Copy link

Qodana for .NET

4 new problems were found

Inspection name Severity Problems
Access to modified captured variable 🔶 Warning 1
Possible 'null' assignment to non-nullable entity 🔶 Warning 1
Collection is never updated (private accessibility) 🔶 Warning 1
Redundant using directive 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8ed6aad) 70.60% compared to head (0123235) 70.50%.

Files Patch % Lines
src/GreenDonut/src/Core/FetchOnceDataLoader.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6919      +/-   ##
==========================================
- Coverage   70.60%   70.50%   -0.11%     
==========================================
  Files        2585     2571      -14     
  Lines      128389   127753     -636     
==========================================
- Hits        90652    90072     -580     
+ Misses      37737    37681      -56     
Flag Coverage Δ
unittests 70.50% <96.36%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit cab7730 into main Feb 19, 2024
98 of 100 checks passed
@michaelstaib michaelstaib deleted the mst/dataloader-fixes branch February 19, 2024 13:17
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant