Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added transient DataLoader state #7387

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Added transient DataLoader state #7387

merged 2 commits into from
Aug 20, 2024

Conversation

michaelstaib
Copy link
Member

No description provided.

@michaelstaib michaelstaib changed the title Added DataLoader state Added transient DataLoader state Aug 20, 2024
@michaelstaib michaelstaib merged commit 856c969 into main Aug 20, 2024
6 checks passed
@michaelstaib michaelstaib deleted the mst/stateful-dataloader branch August 20, 2024 22:11
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 58.73606% with 111 lines in your changes missing coverage. Please review.

Project coverage is 77.27%. Comparing base (6a6d7e6) to head (2f15748).
Report is 1 commits behind head on main.

Files Patch % Lines
src/GreenDonut/src/Core/DataLoaderExtensions.cs 57.81% 27 Missing ⚠️
.../Core/src/Types.Analyzers/Models/DataLoaderInfo.cs 69.73% 23 Missing ⚠️
...Core/src/Types.Analyzers/Helpers/GeneratorUtils.cs 23.07% 20 Missing ⚠️
src/GreenDonut/src/Core/DataLoaderBase.cs 33.33% 14 Missing ⚠️
...pes.Analyzers/Helpers/DataLoaderAttributeHelper.cs 58.06% 13 Missing ⚠️
...es.Analyzers/FileBuilders/DataLoaderFileBuilder.cs 79.54% 9 Missing ⚠️
...ypes.Analyzers/FileBuilders/ResolverFileBuilder.cs 0.00% 3 Missing ⚠️
...ut/src/Core/Attributes/DataLoaderStateAttribute.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7387      +/-   ##
==========================================
+ Coverage   76.79%   77.27%   +0.48%     
==========================================
  Files        2491     2804     +313     
  Lines      123962   140462   +16500     
==========================================
+ Hits        95201   108548   +13347     
- Misses      28761    31914    +3153     
Flag Coverage Δ
unittests 77.27% <58.73%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant