Add PagingOptions.IncludeNodesField option #7396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
IncludeNodesField
option on thePagingOptions
that allows to turn off the generation of thenodes
field on theConnection
type.The nodes fields is mostly for convenience, but it becomes a bit bothersome when using the Relay client and unexperienced Frontend developers. Some of the things that can go wrong and why it might be a good idea to disable the
nodes
field:edges
andnodes
field from different fragments, leading to double the amount of data being returnednodes
is being used, Relay can't delete stuff from the list automatically, because it doesn't "know" about thenodes
field