Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSE formatter error that will cause server slow down. #7401

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

michaelstaib
Copy link
Member

@michaelstaib michaelstaib commented Aug 23, 2024

No description provided.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 46.93878% with 52 lines in your changes missing coverage. Please review.

Project coverage is 77.63%. Comparing base (a350ce1) to head (d0ea022).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...cution/Serialization/EventStreamResultFormatter.cs 57.81% 27 Missing ⚠️
...alization/EventStreamResultFormatterEventSource.cs 19.35% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7401      +/-   ##
==========================================
- Coverage   78.90%   77.63%   -1.27%     
==========================================
  Files        2433     2814     +381     
  Lines      119802   141011   +21209     
==========================================
+ Hits        94530   109477   +14947     
- Misses      25272    31534    +6262     
Flag Coverage Δ
unittests 77.63% <46.93%> (-1.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 6d7bcd2 into main Aug 28, 2024
5 checks passed
@michaelstaib michaelstaib deleted the mst/sse-formatter-errors branch August 28, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant