Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added persisted operation route refinements #7425

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

michaelstaib
Copy link
Member

@michaelstaib michaelstaib commented Sep 3, 2024

  • changed default route from /graphql/q to /graphql/persisted
  • changed display name to the actual operation name
  • added option to require the operation name as part of the route

@michaelstaib michaelstaib merged commit 6145bc2 into main Sep 3, 2024
189 of 190 checks passed
@michaelstaib michaelstaib deleted the mst/persisted-refinements branch September 3, 2024 20:50
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 78.68852% with 13 lines in your changes missing coverage. Please review.

Project coverage is 77.79%. Comparing base (830a96f) to head (997eb29).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...njection/FusionRequestExecutorBuilderExtensions.cs 0.00% 6 Missing ⚠️
...ore/src/AspNetCore/PersistedOperationMiddleware.cs 83.33% 4 Missing ⚠️
...ion/RequestExecutorBuilderExtensions.UseRequest.cs 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7425      +/-   ##
==========================================
- Coverage   78.85%   77.79%   -1.07%     
==========================================
  Files        2445     2818     +373     
  Lines      120325   141246   +20921     
==========================================
+ Hits        94887   109881   +14994     
- Misses      25438    31365    +5927     
Flag Coverage Δ
unittests 77.79% <78.68%> (-1.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant