Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed Persisted Queries to Persisted Operations #7436

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Sep 6, 2024

Summary of the changes (Less than 80 chars)

  • Renamed Persisted Queries to Persisted Operations.

  • ℹ️ The documentation files and URLs have been renamed.
  • 📓 The previous NuGet packages need to be deprecated and have their popularity transferred.
  • ⚠️ There are multiple breaking changes here, please review the changes to the 2 migration documents.

@glen-84 glen-84 marked this pull request as ready for review September 6, 2024 09:23
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.27%. Comparing base (0031a06) to head (480d50d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...njection/FusionRequestExecutorBuilderExtensions.cs 0.00% 2 Missing ⚠️
...s.FileSystem/FileSystemOperationDocumentStorage.cs 83.33% 1 Missing ⚠️
...ations.FileSystem/Properties/Resources.Designer.cs 0.00% 1 Missing ⚠️
...erations.InMemory/Properties/Resources.Designer.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7436      +/-   ##
==========================================
- Coverage   76.82%   76.27%   -0.55%     
==========================================
  Files        2452     2821     +369     
  Lines      120721   141539   +20818     
==========================================
+ Hits        92741   107963   +15222     
- Misses      27980    33576    +5596     
Flag Coverage Δ
unittests 76.27% <91.66%> (-0.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 3e18db9 into main Sep 6, 2024
11 checks passed
@michaelstaib michaelstaib deleted the gai/persisted-queries-rename branch September 6, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants