Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete methods: RemovePath and RemoveLocations #7849

Closed

Conversation

JesseXia
Copy link

Summary

According to graphql spec -

The path and the error is always required in the field execution context.

The existing methods are now obsolete.

Closes #7828

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ JesseXia
❌ greaterwill
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.37%. Comparing base (61f1f59) to head (6d809b5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7849      +/-   ##
==========================================
- Coverage   74.39%   74.37%   -0.02%     
==========================================
  Files        2876     2876              
  Lines      150071   150065       -6     
  Branches    17450    17447       -3     
==========================================
- Hits       111641   111618      -23     
- Misses      32613    32631      +18     
+ Partials     5817     5816       -1     
Flag Coverage Δ
unittests 74.37% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JesseXia JesseXia marked this pull request as ready for review December 21, 2024 09:40
@JesseXia JesseXia closed this Dec 21, 2024
@JesseXia JesseXia reopened this Dec 21, 2024
@JesseXia
Copy link
Author

Interesting, I have signed the CLA already but the CLA check still doesn't work tho.

@JesseXia JesseXia closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove RemoveLocation and RemovePath methods from error and error builder.
3 participants