Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ list, in operator and size function support #20

Merged

Conversation

alvaro-saavedra-sumup
Copy link
Contributor

@alvaro-saavedra-sumup alvaro-saavedra-sumup commented Feb 20, 2024

Describe your changes

Add support for lists and list operations, used spects from cel-spec.

Issue ticket number/link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests (if possible)

@ChromeGG ChromeGG changed the title Features/add support for lists feat: ✨ List, in operator and size function support Feb 21, 2024
Copy link
Owner

@ChromeGG ChromeGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Thank you for contribution! <3

There are some small thing to adjust, I left todos. I can start fixing it in 10h

src/spec/lists.spec.ts Outdated Show resolved Hide resolved
@ChromeGG ChromeGG mentioned this pull request Feb 21, 2024
2 tasks
@ChromeGG ChromeGG changed the title feat: ✨ List, in operator and size function support feat: ✨ list, in operator and size function support Feb 21, 2024
@ChromeGG
Copy link
Owner

Note to myself: do NOT forget to update demo.ts and release it :)

@ChromeGG
Copy link
Owner

Unfortunately there is a couple of todos we should address. If you really need this feature released soon, I can marge and release it in this form. Otherwise I prefer to rethink the implementation to handle edge-cases like [1,2,3][1] and [1][5]

@alvaro-saavedra-sumup
Copy link
Contributor Author

Unfortunately there is a couple of todos we should address. If you really need this feature released soon, I can marge and release it in this form. Otherwise I prefer to rethink the implementation to handle edge-cases like [1,2,3][1] and [1][5]

Don't worry, let me check how to address them. I think I will work on them this week end.

src/helper.ts Show resolved Hide resolved
@ChromeGG ChromeGG merged commit dfb3683 into ChromeGG:main Feb 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants