feat: ✨ map support #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChromeGG
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Amazing job, man! Thank you for you contribution! <3
We have to remember about two small things:
- Always run regenerate
cst-definitios.ts, - Format code using default prettier rules.
ideally, it should be part of the CI.
Optionally, you can fix the PR issues. PR has my approval, so it will be merged and released in the next 3 days 😄
PS What is your motivation for supporting this open source? Are you using it in your company? 😄
Not "yet", I did a POC for an internal usage software, and I was missing some features, but now is just for fun. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add support for maps
Checklist before requesting a review