Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge storybook-prep improvements #56

Closed
wants to merge 8 commits into from

Conversation

thomassth
Copy link

Merging cleanup efforts from storybook-prep branch

  • Radium calls updated
  • Connect calls updated

@patcon
Copy link
Member

patcon commented Oct 24, 2024

I have no opinion on whether this goes into edge-civictechto (I hope to upstream it later), but pls ensure it doesn't get deleted -- it's intended to be a long-lived branch, not a feature branch :)

@NewJerseyStyle
Copy link
Member

NewJerseyStyle commented Dec 20, 2024

Any relationship with #100 ? @yshng any idea?

@thomassth thomassth marked this pull request as draft December 20, 2024 21:58
@thomassth
Copy link
Author

Probably superceded by #93, close after that's done

@patcon
Copy link
Member

patcon commented Dec 20, 2024

To explain: this branch only existed to be the minimal changeset upstream needed to get storybook working. it's a tracking branch, and wasn't expected to be merged/deleted locally until the changes were no longer needed upstream

@patcon
Copy link
Member

patcon commented Dec 20, 2024

The polis-storybook repo should be relying on this still. This PR is a prob a bit confusing in its existence, bc the only diff that matters for my purposes is against upstream edge: compdemocracy/polis@edge...CivicTechTO:polis:storybook-prep

I would recommend closing this PR and maybe protecting the branch (it's too bad that it's not easy to add notes to branches about why they exist)

@NewJerseyStyle
Copy link
Member

Every time I saw the PR title and the message at the top by @thomassth I get confused if any action should take 🤣

@patcon patcon closed this Dec 22, 2024
@patcon
Copy link
Member

patcon commented Dec 22, 2024

Solved? Pls re-open if I've misunderstood :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants