-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge storybook-prep
improvements
#56
Conversation
…nts. This easily side-steps issue of custom decorator not working in Storybook.
I have no opinion on whether this goes into |
Probably superceded by #93, close after that's done |
To explain: this branch only existed to be the minimal changeset upstream needed to get storybook working. it's a tracking branch, and wasn't expected to be merged/deleted locally until the changes were no longer needed upstream |
The polis-storybook repo should be relying on this still. This PR is a prob a bit confusing in its existence, bc the only diff that matters for my purposes is against upstream I would recommend closing this PR and maybe protecting the branch (it's too bad that it's not easy to add notes to branches about why they exist) |
Every time I saw the PR title and the message at the top by @thomassth I get confused if any action should take 🤣 |
Solved? Pls re-open if I've misunderstood :) |
Merging cleanup efforts from
storybook-prep
branch