Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Betweelands compat #285

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

WaitingIdly
Copy link
Collaborator

changes in this PR:

  • add compat with The Betweelands animator, compost, crabPotFilterBubbler, crabPotFilterSilt, druidAltar, pestleAndMortar, purifier, smokingRack, and steepingPot. examples and i18n for those.
    • note that testing this in development cannot be done via a simple boolean change, and the jar must be manually placed in the run/mods folder. a TODO to fix this and a link to download the mod are present.
    • requires accessor mixins to function.
  • add the IOreDicts interface as a way to unify access to OreDictIngredient and OreDictWildcardIngredient.
    • add a TODO to check instanceof IOreDicts in favor of instanceof OreDictIngredient to ensure OreDictWildcardIngredient has support.
  • add IngredientHelper#cartesianProductOres and IngredientHelper#cartesianProductItemStacks to consolidate use of Lists#cartesianProduct.
    • this is useful for recipes which take multiple itemstack (or itemstack/oredict) inputs, to ensure all combinations of the recipe provided are faithfully added (currently, there are some cases in which only the first entry of the array is used).
    • apply this in multiple recipe builders, primarily Cyclic.
  • remove strip-latest-forge-requirements from the dependencies.gradle and enable the gradle.properties setting to load the same mod via the build.gradle buildscript.
  • add a runtime_dependencies map for mods that dont need to be compiled.
    • consolidate existing runtimeOnly uses into this map.
    • add actually_advanced_info, mouse_tweaks_unofficial, roughly_enough_ids, universal_tweaks, and vintagefix to the runtime_dependencies map, and add corresponding debug properties.

@WaitingIdly WaitingIdly added the mod compat Relating to compatability with a mod or features of a mod label Jan 7, 2025
# Conflicts:
#	src/main/java/com/cleanroommc/groovyscript/helper/ingredient/OreDictIngredient.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod compat Relating to compatability with a mod or features of a mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant