generated from CleanroomMC/TemplateDevEnv
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Betweelands compat #285
Open
WaitingIdly
wants to merge
15
commits into
CleanroomMC:master
Choose a base branch
from
WaitingIdly:betweenlands
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaitingIdly
added
the
mod compat
Relating to compatability with a mod or features of a mod
label
Jan 7, 2025
# Conflicts: # src/main/java/com/cleanroommc/groovyscript/helper/ingredient/OreDictIngredient.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes in this PR:
animator
,compost
,crabPotFilterBubbler
,crabPotFilterSilt
,druidAltar
,pestleAndMortar
,purifier
,smokingRack
, andsteepingPot
. examples and i18n for those.run/mods
folder. a TODO to fix this and a link to download the mod are present.IOreDicts
interface as a way to unify access toOreDictIngredient
andOreDictWildcardIngredient
.instanceof IOreDicts
in favor ofinstanceof OreDictIngredient
to ensureOreDictWildcardIngredient
has support.IngredientHelper#cartesianProductOres
andIngredientHelper#cartesianProductItemStacks
to consolidate use ofLists#cartesianProduct
.strip-latest-forge-requirements
from thedependencies.gradle
and enable thegradle.properties
setting to load the same mod via thebuild.gradle
buildscript.runtime_dependencies
map for mods that dont need to be compiled.runtimeOnly
uses into this map.actually_advanced_info
,mouse_tweaks_unofficial
,roughly_enough_ids
,universal_tweaks
, andvintagefix
to theruntime_dependencies
map, and add correspondingdebug
properties.