Skip to content

Commit

Permalink
Merge pull request #1778 from CliMA/ck/fix_dss_type_param
Browse files Browse the repository at this point in the history
Fix dss type param
  • Loading branch information
charleskawczynski authored Jun 4, 2024
2 parents c6bf4aa + b8d42e7 commit 7038214
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "ClimaCore"
uuid = "d414da3d-4745-48bb-8d80-42e94e092884"
authors = ["CliMA Contributors <clima-software@caltech.edu>"]
version = "0.14.6"
version = "0.14.7"

[deps]
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
Expand Down
8 changes: 4 additions & 4 deletions ext/cuda/topologies_dss.jl
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ _configure_threadblock(nitems) =
function Topologies.dss_load_perimeter_data!(
::ClimaComms.CUDADevice,
dss_buffer::Topologies.DSSBuffer,
data::Union{DataLayouts.IJFH{S, Nij}, DataLayouts.VIJFH{S, Nij}},
data::Union{DataLayouts.IJFH, DataLayouts.VIJFH},
perimeter::Topologies.Perimeter2D,
) where {S, Nij}
)
pperimeter_data = parent(dss_buffer.perimeter_data)
pdata = parent(data)
(nlevels, nperimeter, nfid, nelems) = size(pperimeter_data)
Expand Down Expand Up @@ -56,10 +56,10 @@ end

function Topologies.dss_unload_perimeter_data!(
::ClimaComms.CUDADevice,
data::Union{DataLayouts.IJFH{S, Nij}, DataLayouts.VIJFH{S, Nij}},
data::Union{DataLayouts.IJFH, DataLayouts.VIJFH},
dss_buffer::Topologies.DSSBuffer,
perimeter,
) where {S, Nij}
)
pperimeter_data = parent(dss_buffer.perimeter_data)
pdata = parent(data)
(nlevels, nperimeter, nfid, nelems) = size(pperimeter_data)
Expand Down
8 changes: 4 additions & 4 deletions src/Spaces/dss.jl
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ perimeter(space::AbstractSpectralElementSpace) = Topologies.Perimeter2D(
Creates a [`DSSBuffer`](@ref) for the field data corresponding to `data`
"""
function create_dss_buffer(
data::Union{DataLayouts.IJFH{S, Nij}, DataLayouts.VIJFH{S, <:Any, Nij}},
data::Union{DataLayouts.IJFH, DataLayouts.VIJFH},
hspace::SpectralElementSpace2D,
) where {S, Nij}
)
create_dss_buffer(
data,
topology(hspace),
Expand All @@ -39,9 +39,9 @@ function create_dss_buffer(
end

function create_dss_buffer(
data::Union{DataLayouts.IFH{S, Nij}, DataLayouts.VIFH{S, <:Any, Nij}},
data::Union{DataLayouts.IFH, DataLayouts.VIFH},
hspace::SpectralElementSpace1D,
) where {S, Nij}
)
nothing
end

Expand Down
2 changes: 1 addition & 1 deletion src/Topologies/dss.jl
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,7 @@ end
Computed unweighted/pure DSS of `data`.
"""
function dss!(
data::Union{DataLayouts.IJFH{S, Nij}, DataLayouts.VIJFH{S, Nij}},
data::Union{DataLayouts.IJFH{S, Nij}, DataLayouts.VIJFH{S, <:Any, Nij}},
topology::Topology2D,
) where {S, Nij}
length(parent(data)) == 0 && return nothing
Expand Down
2 changes: 1 addition & 1 deletion src/Topologies/dss_transform.jl
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ recv_buffer(ghost::GhostBuffer) = ghost.recv_data
create_ghost_buffer(data, topology::Topologies.AbstractTopology) = nothing

function create_ghost_buffer(
data::Union{DataLayouts.IJFH{S, Nij}, DataLayouts.VIJFH{S, Nij}},
data::Union{DataLayouts.IJFH{S, Nij}, DataLayouts.VIJFH{S, <:Any, Nij}},
topology::Topologies.Topology2D,
) where {S, Nij}
if data isa DataLayouts.IJFH
Expand Down

2 comments on commit 7038214

@charleskawczynski
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/108189

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.14.7 -m "<description of version>" 7038214c1dfdacbe7e57e5f8527cac18c8dc954d
git push origin v0.14.7

Please sign in to comment.