Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compact syntax for overlapping multiple DSS calls #1573

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Add compact syntax for overlapping multiple DSS calls #1573

merged 2 commits into from
Dec 6, 2023

Conversation

simonbyrne
Copy link
Member

This addresses the multiple-sync issue we're seeing on GPUs, and also simplifies the interface considerably.

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

@simonbyrne simonbyrne marked this pull request as ready for review December 6, 2023 17:36
@sriharshakandala
Copy link
Member

Looks good to me!

@simonbyrne simonbyrne enabled auto-merge December 6, 2023 18:23
@simonbyrne simonbyrne mentioned this pull request Dec 6, 2023
Merged
1 task
@simonbyrne simonbyrne merged commit e3a2d60 into main Dec 6, 2023
15 checks passed
@simonbyrne simonbyrne deleted the sb/buffer-pair branch December 6, 2023 22:36
@simonbyrne simonbyrne mentioned this pull request Dec 11, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriharshakandala sriharshakandala sriharshakandala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonbyrne @sriharshakandala