-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for deep atmosphere #1606
Conversation
b378096
to
528af66
Compare
528af66
to
c81d857
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Sbozzolo. This is ready to rebase and merge with the included changes against commit c81d857
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few more comments, but overall looks good.
Thanks @charleskawczynski ! My opinion is that the questions about |
7234aa6
to
6b72f7e
Compare
I rebased, squashed, and addressed the comment on |
Co-authored-by: Akshay Sridhar <asridhar@caltech.edu> Co-authored-by: Gabriele Bozzola <gbozzola@caltech.edu>
6b72f7e
to
a293ea9
Compare
This is a rebased and cleaned (from a git perspective) version of #1591 (authorship is preserved).
This PR adds supports for deep atmospheres and changes a little bit the hypsography interface.
I am not particularly satisfied with the current hypsography interface, in particular in relation with the interpolation methods.
Among the problems are:
ZPoints
. The interpolation interface works with scalars, the hypsography withZPoints
, so there are conversions that need to be done between the twoIn the interest of merging support for deep atmosphere, we can go ahead with this PR and tackle the issues with hypsography/interpolation in the future.
Closes #1524