Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert commit "Add IJFVH datalayout (work in progress)" #1960

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Revert commit "Add IJFVH datalayout (work in progress)" #1960

merged 1 commit into from
Aug 29, 2024

Conversation

sriharshakandala
Copy link
Member

@sriharshakandala sriharshakandala commented Aug 29, 2024 •
edited
Loading

Revert commit "Add IJFVH datalayout (work in progress)" (6ac7b71)

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

Sbozzolo
Sbozzolo approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@Sbozzolo Sbozzolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add a comment to PR description to explain what has happened and why a commit is being reverted

@Sbozzolo Sbozzolo merged commit a207bfc into main Aug 29, 2024
22 of 23 checks passed
@Sbozzolo Sbozzolo deleted the sk/revert_commit branch August 29, 2024 06:22
@charleskawczynski
Copy link
Member

@sriharshakandala, was 6ac7b71) somehow committed directly to the main branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sbozzolo Sbozzolo Sbozzolo approved these changes

@dennisYatunin dennisYatunin Awaiting requested review from dennisYatunin

@charleskawczynski charleskawczynski Awaiting requested review from charleskawczynski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sriharshakandala @charleskawczynski @Sbozzolo