Add element mask to SpectralElementGrid2D
#2085
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sriharshakandala
force-pushed
the
sk/add_elemmask
branch
from
c088679 to
3185e14
Compare
sriharshakandala
force-pushed
the
sk/add_elemmask
branch
from
3185e14 to
2121eeb
Compare
sriharshakandala
force-pushed
the
sk/add_elemmask
branch
from
e31aeb8 to
690c95c
Compare
|
Heads-up: you'll also need to change InputOutput to make sure that this is compatible with restarts |
Sbozzolo
reviewed
Dec 4, 2024
| @@ -138,11 +139,12 @@ mutable struct SpectralElementGrid2D{ | |||
| internal_surface_geometry::IS | |||
| boundary_surface_geometries::BS | |||
| enable_bubble::Bool | |||
| element_mask::EM | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| function set_mask!(space::AbstractSpace, mask::Field) |
with Spaces.horizontal_space(axes(mask)) == Spaces.horizontal_space(axes(sapce))
sriharshakandala
force-pushed
the
sk/add_elemmask
branch
from
3324c73 to
270cb57
Compare
sriharshakandala
force-pushed
the
sk/add_elemmask
branch
from
270cb57 to
29d0e98
Compare
| @@ -176,6 +179,8 @@ where ``\\tilde{A}^e`` is the approximated area given by the sum of the interior | |||
|
|
|||
| Note: This is accurate only for cubed-spheres of the [`Meshes.EquiangularCubedSphere`](@ref) and | |||
| [`Meshes.EquidistantCubedSphere`](@ref) type, not for [`Meshes.ConformalCubedSphere`](@ref). | |||
|
|
|||
| The element mask can be used to block evaluation of tendencies for spectral elements for which it is set to `false`. | |||
There was a problem hiding this comment.
Suggested change
| The element mask can be used to block evaluation of tendencies for spectral elements for which it is set to `false`. | |
| The element mask can be used to skip evaluation of broadcast expressions for spectral elements with the mask set to `false`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add element mask to
SpectralElementGrid2D