Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

[WIP] Unique url for view_all_submissions and my_submission #322

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Kajol-Kumari
Copy link
Member

@Kajol-Kumari Kajol-Kumari commented May 24, 2020

This PR includes:

  • Corrected url path for my_submissions and view_all_submissions
  • Changed the unique url to slug based
  • Add unique url access for view_all_submissions

work to be done:

  • Fix the unique url implemented in this PR for my_submission and view_all_submissions

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2020

Codecov Report

Merging #322 into master will decrease coverage by 0.16%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
- Coverage   50.63%   50.47%   -0.17%     
==========================================
  Files          66       66              
  Lines        3772     3784      +12     
  Branches      444      450       +6     
==========================================
  Hits         1910     1910              
- Misses       1767     1779      +12     
  Partials       95       95              
Impacted Files Coverage Δ
...lengesubmissions/challengesubmissions.component.ts 35.29% <0.00%> (-1.17%) ⬇️
...bmissions/challengeviewallsubmissions.component.ts 30.84% <0.00%> (-0.89%) ⬇️
src/app/services/endpoints.service.ts 64.89% <0.00%> (ø)
Impacted Files Coverage Δ
...lengesubmissions/challengesubmissions.component.ts 35.29% <0.00%> (-1.17%) ⬇️
...bmissions/challengeviewallsubmissions.component.ts 30.84% <0.00%> (-0.89%) ⬇️
src/app/services/endpoints.service.ts 64.89% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a348206...d94e237. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants