Minor log improvements #3782
Merged
Minor log improvements #3782
+81
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and reformat code more cleanly
Use appropriate PRI constant for flag format, and use pcmk__s() convenience macro where appropriate.
Utilization doesn't apply to bundle nodes; if the bundled primitive has utilization, it applies to the container's host, not the bundle node.
If we weren't going to do anything anyway, don't bother logging that we're not doing it at shutdown.
For example, pcmk__check_action_config() dumps resource configuration XML at debug level, which could include sensitive parameter values.
If the test is interrupted and fails to restore the backup, at least it will be where the admin can easily find it. delete=true is the default for NamedTemporaryFile(), so we don't need to specify it expicitly
|
@clumens , can you review this when you get a chance? Thanks |
clumens
approved these changes
Jan 8, 2025
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.