Implemented Item unit of measure component #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mkumbobeaty
commented
Mar 15, 2019
mkumbobeaty
commented
- closes I should be able to search for unit of measures I should be able to search for unit of measures #105
- closes I should be able to edit unit of measure I should be able to edit unit of measure #106
- closes I should be able to refresh list of unit of measures I should be able to refresh list of unit of measures #107
- closes I should be able to archive unit of measure I should be able to archive unit of measure #108
- closes I should be able to paginating list of unit of measures I should be able to paginating list of unit of measures #103
- closes I should be able to create unit of measure I should be able to create unit of measure #102
- closes I should be able to view list of unit of measures I should be able to view list of unit of measures #101
…to feature/uom
add ellipsize description and on hover display full text
BenMaruchu
requested changes
Mar 17, 2019
src/layouts/BaseLayout.js
Outdated
| title: 'List of available warehouses', | ||
| '/resources/itemunit': { | ||
| name: 'Item Unit', | ||
| title: 'List of available Item unit of measure', |
There was a problem hiding this comment.
Can this be List of available units of measure for items
src/layouts/BaseLayout.js
Outdated
| '/resources/warehouses': { | ||
| name: 'Warehouses', | ||
| title: 'List of available warehouses', | ||
| '/resources/itemunit': { |
There was a problem hiding this comment.
I think this should be `unitsofmeasure
navish
requested changes
Mar 18, 2019
BenMaruchu
requested changes
Mar 19, 2019
BenMaruchu
requested changes
Mar 19, 2019
…to feature/uom
…into feature/uom
BenMaruchu
approved these changes
Mar 19, 2019
navish
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.