fix: vscode extension fails to start due to canvas dependency being i…

…ncorrectly required by jsdom
Codeneos · Sep 29, 2022 · 4b8d281 · 4b8d281
1 parent 8c6a031
commit 4b8d281
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/packages/cli/webpack/webpack.ts b/packages/cli/webpack/webpack.ts
@@ -9,8 +9,7 @@ import * as packageJson from '../package.json';
 const packageExternals = [
     'vscode',
     'vscode-languageclient',
-    'electron',
-    'canvas'
+    'electron'
 ];
 
 const contextFolder = path.resolve(__dirname, '..');
@@ -102,6 +101,10 @@ const common : webpack.Configuration = {
     },
     plugins: [
         new WatchMarkersPlugin(),
+        new webpack.IgnorePlugin({
+            resourceRegExp: /^canvas$/,
+            contextRegExp: /jsdom$/,
+        }),
         new webpack.DefinePlugin({
             __webpack_build_info__: JSON.stringify({ 
                 version: packageJson.version, 

diff --git a/packages/vscode-extension/webpack/webpack.common.ts b/packages/vscode-extension/webpack/webpack.common.ts
@@ -17,8 +17,7 @@ const packageExternals = [
     // VSCode is an external that we do not want to package
     'vscode',
     'vscode-languageclient',
-    'electron',
-    'canvas'
+    'electron'
 ];
 
 const contextFolder = path.resolve(__dirname, '..');
@@ -98,7 +97,11 @@ const common : webpack.Configuration = {
         devtoolModuleFilenameTemplate: '[absolute-resource-path]'
     },
     plugins: [
-        new WatchMarkersPlugin()
+        new WatchMarkersPlugin(),
+        new webpack.IgnorePlugin({
+            resourceRegExp: /^canvas$/,
+            contextRegExp: /jsdom$/,
+        })
     ],
     node: {
         __dirname: false,
@@ -162,7 +165,7 @@ const common : webpack.Configuration = {
     externals: function({ request }, callback) {
         const isExternal = packageExternals.some(
             moduleName => request && new RegExp(`^${moduleName}(/|$)`, 'i').test(request)
-        );
+        )        
         if (isExternal){
             // @ts-ignore
             return callback(undefined, `commonjs ${request}`);