feat: custom action fix

[himanshu-dixit]

🔍 Review Summary

Minor updates were made to langchain.spec.ts and base.toolset.ts to enhance the efficiency of custom action processing.

Original Description

[!IMPORTANT]
Fixes custom action filtering in ComposioToolSet and adds a test for custom action retrieval.

• Behavior:
  • Fixes filtering logic for custom actions in getToolsSchema() in base.toolset.ts by removing unnecessary toolName filter.
  • Adds test in langchain.spec.ts to verify custom action retrieval with getTools().
• Tests:
  • Adds expectation for tools.length to be 1 after retrieving custom action starRepositoryCustomAction in langchain.spec.ts.

^{This description was created by for 4c4d743. It will automatically update as commits are pushed.}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
composio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 3, 2025 9:03am

[entelligence-ai-pr-reviews]

Walkthrough

Minor changes in langchain.spec.ts and base.toolset.ts to streamline custom action handling.

🔗 Related PRs

• feat: update types with BE and release rc for v0.5 #1082: The text outlines a significant refactor of backend types and API methods, including function renamings, model updates, and service method adjustments to align with new specifications.
• fix: bring eslint + TS issues to zero #1013: The pull request aims to enhance code quality and type safety by enforcing stricter ESLint rules, refactoring code, and improving error handling. Changes include replacing any with specific types and adding type definitions for better maintainability and readability.
• feat: decrease bundle size, eslint and ts issues to zero  #1032: The update optimizes the Composio JS SDK by automating version bumps, reducing JavaScript bundle size, and enhancing documentation and linting processes.
• chore: Release v0.6.8 #1092: The pull request updates the version to 0.6.8 for core and plugins and 0.3.9 for SWE Kit, while also modifying the workflow for editable installation.

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

• ⚠️ Potential Issue - May require further investigation.
• 🔒 Security Vulnerability - Fix to ensure system safety.
• 💻 Code Improvement - Suggestions to enhance code quality.
• 🔨 Refactor Suggestion - Recommendations for restructuring code.
• ℹ️ Others - General comments and information.

Interact with the Bot:

• Send a message or request using the format:
  @bot + *your message*

Example: @bot Can you suggest improvements for this code?

• Help the Bot learn by providing feedback on its responses.
  @bot + *feedback*

Example: @bot Do not comment on `save_auth` function !

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 4c4d743 in 37 seconds

More details

• Looked at 45 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. js/src/frameworks/langchain.spec.ts:68

• Draft comment:
  expect should not be awaited as it is not a promise.

    expect(tools.length).toBe(1);

• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_ZYt63caQvjTp4edd

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

expect should not be awaited as it is not a promise.

Suggested change

	await expect(tools.length).toBe(1);
	expect(tools.length).toBe(1);

[github-actions]

This comment was generated by github-actions[bot]!

JS SDK Coverage Report

📊 Coverage report for JS SDK can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/coverage-12595298076/coverage/index.html

📁 Test report folder can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/html-report-12595298076/html-report/report.html

[shreysingla11]

Good improvement adding proper async/await handling here. This prevents potential race conditions and makes the code more reliable. However, consider adding a test description that better explains what's being tested, e.g.:

it('should return exactly one tool when requesting starRepositoryCustomAction', async () => {
  // ... rest of the test
});

[shreysingla11]

Consider adding null/undefined checks for the action object since you're destructuring it directly. A safer approach would be:

const { name: actionName } = action?.metadata || {};

This prevents potential runtime errors if action is null/undefined.

[shreysingla11]

Code Review Summary

Overall, the changes look good and improve the codebase in several ways:

Positive Changes:

✅ Added proper async/await handling in test file
✅ Simplified custom actions filtering logic
✅ Improved test coverage for custom actions
✅ Removed redundant filtering conditions

Suggestions for Improvement:

1. Add better test descriptions for clarity
2. Add null/undefined checks when destructuring objects
3. Consider documenting the removal of toolName filtering in case other parts of the system relied on it

Code Quality: 8/10

The changes make the code more maintainable and reliable while maintaining functionality. The removal of redundant filtering improves code clarity.