fix tests

ConduitIO · Nov 4, 2024 · f0dde31 · f0dde31
1 parent 3bc7d2d
commit f0dde31
Showing 1 changed file with 18 additions and 5 deletions.
diff --git a/pkg/processor/service_test.go b/pkg/processor/service_test.go
@@ -16,6 +16,7 @@ package processor
 
 import (
 	"context"
+	"strings"
 	"testing"
 
 	"github.com/conduitio/conduit-commons/database/inmemory"
@@ -388,15 +389,17 @@ func TestService_Update_Success(t *testing.T) {
 			"processor-config-field-2": "bar",
 		},
 	}
+	newProcType := "new-proc-type"
 
-	got, err := service.Update(ctx, want.ID, procType, newConfig)
+	got, err := service.Update(ctx, want.ID, newProcType, newConfig)
 	is.NoErr(err)
 	is.Equal(want, got)             // same instance is returned
 	is.Equal(newConfig, got.Config) // config was updated
 
 	got, err = service.Get(ctx, want.ID)
 	is.NoErr(err)
 	is.Equal(newConfig, got.Config)
+	is.Equal(newProcType, got.Plugin)
 }
 
 func TestService_Update_NonExistentProcessor(t *testing.T) {
@@ -414,11 +417,21 @@ func TestService_Update_EmptyPluginName(t *testing.T) {
 	is := is.New(t)
 	ctx := context.Background()
 	db := &inmemory.DB{}
-	service := NewService(log.Nop(), db, &proc_plugin.PluginService{})
 
-	got, err := service.Update(ctx, "non-existent processor", "test-processor", Config{})
-	is.True(cerrors.Is(err, ErrInstanceNotFound)) // expected instance not found error
-	is.Equal(got, nil)
+	procType := "processor-type"
+	p := proc_mock.NewProcessor(gomock.NewController(t))
+	p.EXPECT().Teardown(ctx).Return(nil)
+
+	registry := newPluginService(t, map[string]sdk.Processor{procType: p})
+	service := NewService(log.Nop(), db, registry)
+
+	// create a processor instance
+	want, err := service.Create(ctx, uuid.NewString(), procType, Parent{}, Config{}, ProvisionTypeAPI, "")
+	is.NoErr(err)
+
+	_, err = service.Update(ctx, want.ID, "", Config{})
+	is.True(err != nil)
+	is.True(strings.Contains(err.Error(), "plugin name is empty"))
 }
 
 // newPluginService creates a registry with builders for the supplied