Merge pull request #162 from ConnectAI-E/feature-lloyd-202401230

hotfix: set max commit message length. #146
ConnectAI-E · Jan 30, 2024 · a100e10 · a100e10
2 parents f411536 + 7bbd938
commit a100e10
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/server/utils/constant.py b/server/utils/constant.py
@@ -23,3 +23,6 @@ class TopicType(Enum):
 
 class GitHubPermissionError(Exception):
     pass
+
+
+MAX_COMMIT_MESSAGE_LENGTH = 40
diff --git a/server/utils/lark/pr_tip_commit_history.py b/server/utils/lark/pr_tip_commit_history.py
@@ -1,3 +1,4 @@
+from utils.constant import MAX_COMMIT_MESSAGE_LENGTH
 from utils.github.model import Commit
 
 from .base import *
@@ -10,8 +11,8 @@ def __init__(
     ):
         def process_commit_message(message: str) -> str:
             title = message.split("\n")[0] if "\n" in message else message
-            if len(title) > 23:
-                title = title[:20] + "..."
+            if len(title) > (MAX_COMMIT_MESSAGE_LENGTH + 3):
+                title = title[:MAX_COMMIT_MESSAGE_LENGTH] + "..."
             return title
 
         content = "\n".join(
Original file line number	Diff line number	Diff line change
Expand Up		@@ -23,3 +23,6 @@ class TopicType(Enum):

		class GitHubPermissionError(Exception):
		pass


		MAX_COMMIT_MESSAGE_LENGTH = 40