Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken schematic files are not handled properly #6087

Open
goteusz-maszyk opened this issue Feb 7, 2024 · 1 comment
Open

Broken schematic files are not handled properly #6087

goteusz-maszyk opened this issue Feb 7, 2024 · 1 comment
Labels
status: fixed in next release Issue will be fixed in the next release type: bug Issue where something isn't working

Comments

@goteusz-maszyk
Copy link

Describe the Bug

When a player uploads a schematic, it should be checked if it's a correct ZIP-NBT schematic and not throw the error to console.

Reproduction Steps

  1. Make a broken schematic file, such as one provided below
  2. Upload it to create server
  3. See that the server logs go crazy with a java.util.zip.ZipException: Not in GZIP format

Expected Result

A player should receive a polite message informing that the schematic file is invalid and they cannot use it.

Screenshots and Videos

huh.nbt.zip

Crash Report or Log

No response

Operating System

Nobara 39

Mod Version

0.5.1f

Minecraft Version

1.20.1

Forge Version

Neo 47.1.96

Other Mods

No response

Additional Context

Fabricators-of-Create#1298

@goteusz-maszyk goteusz-maszyk added the type: bug Issue where something isn't working label Feb 7, 2024
@goteusz-maszyk
Copy link
Author

goteusz-maszyk commented Feb 7, 2024

Also, related suggestion: when you upload the schematic, the server doesn't check if it was already uploaded (by a checksum, for example) making it consume internet connection for no reason

EDIT: Reopen cuz I clicked the wrong button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: fixed in next release Issue will be fixed in the next release type: bug Issue where something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants