Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken schematic files are not handled properly #1298

Closed
goteusz-maszyk opened this issue Feb 5, 2024 · 3 comments
Closed

Broken schematic files are not handled properly #1298

goteusz-maszyk opened this issue Feb 5, 2024 · 3 comments
Labels
type: bug Issue where something isn't working type: upstream This is inherited from upstream Forge Create. It is highly unlikely we will change it.

Comments

@goteusz-maszyk
Copy link

Describe the Bug

When a player uploads a schematic, it should be checked if it's a correct ZIP-NBT schematic and not throw the error to console.

Reproduction Steps

  1. Make a broken schematic file, such as one provided below
  2. Upload it to create server
  3. See that the server logs go crazy with a java.util.zip.ZipException: Not in GZIP format

Expected Result

A player should receive a polite message informing that the schematic file is invalid and they cannot use it.

Screenshots and Videos

huh.nbt.zip

Crash Report or Log

No response

Operating System

Nobara 39

Mod Version

0.5.1d

Minecraft Version

1.20.1

Other Mods

No response

Additional Context

No response

@goteusz-maszyk goteusz-maszyk added the type: bug Issue where something isn't working label Feb 5, 2024
@goteusz-maszyk
Copy link
Author

NOTE: it also happens on forge, should I send it to Creators-of-Create/Create or is it ok here?

@TropheusJ
Copy link
Member

report to the forge repo

@TropheusJ TropheusJ added the type: upstream This is inherited from upstream Forge Create. It is highly unlikely we will change it. label Feb 5, 2024
@TropheusJ
Copy link
Member

Issues that occur on Forge as well are no longer being tracked on this repo. Please follow the respective issue on the Forge repo instead: Creators-of-Create#6087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issue where something isn't working type: upstream This is inherited from upstream Forge Create. It is highly unlikely we will change it.
Projects
None yet
Development

No branches or pull requests

2 participants