[#186590795]: Implement squared weights in cr.cube
#391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #391 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 4557 4620 +63
=========================================
+ Hits 4557 4620 +63 ☔ View full report in Codecov by Sentry. |
slobodan-ilic
force-pushed
the
squared-weights-186590795
branch
from
df0ab13 to
51d04b1
Compare
slobodan-ilic
force-pushed
the
squared-weights-186590795
branch
from
95339a3 to
37c39ca
Compare
slobodan-ilic
force-pushed
the
squared-weights-186590795
branch
from
37c39ca to
9443014
Compare
malecki
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements access to a new cube measure - weighted squared counts. This is needed for working with the design effect in the pairwise column comparisons. We'll use it by calculating a design effect and multiply the relevant denominators (for pairwise significance) by it (by the design effect).