Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deepcopy from the codebase #395

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

ernestoarbitrio
Copy link
Contributor

https://www.pivotaltracker.com/story/show/187090869

deepcopy(s) causing OOM on task system

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (31d3df8) to head (e8909f2).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #395   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         4621      4627    +6     
=========================================
+ Hits          4621      4627    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@rikirenz rikirenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I believe this will solve the spikes in memory.

I have just 1 small question. Please let me know.

src/cr/cube/dimension.py Show resolved Hide resolved
src/cr/cube/dimension.py Show resolved Hide resolved
src/cr/cube/dimension.py Show resolved Hide resolved
src/cr/cube/dimension.py Show resolved Hide resolved
@ernestoarbitrio ernestoarbitrio merged commit aaaacb5 into master Feb 26, 2024
6 checks passed
@ernestoarbitrio ernestoarbitrio deleted the get-rid-of-deepcopy-187090869 branch February 26, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants